Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display active tag script #1009

Closed
ToksT opened this issue Mar 20, 2013 · 4 comments
Closed

Display active tag script #1009

ToksT opened this issue Mar 20, 2013 · 4 comments

Comments

@ToksT
Copy link
Contributor

ToksT commented Mar 20, 2013

When using the "Apply tag script" mode, it would be convenient if the preset script was visible somewhere on the page. This would prevent accidentally applying the wrong tag script for those who frequently use different ones.

@ToksT
Copy link
Contributor Author

ToksT commented Apr 24, 2013

Actually, I took this a step further:

  • The popup when editing the tag script is replaced by an input field under the mode menu that allows you to type a tag script in.
  • When in apply tag script mode, that same input field will be visible, allowing you to view the tag script.

Does anyone object to this change of the edit tag script mode before I commit this?

@kittey
Copy link
Contributor

kittey commented Apr 24, 2013

When in apply tag script mode, can the input field be changed?

Also, wouldn't it now be better to merge edit and apply tag script modes? If the input field can always be changed (while some tag script mode is one), just apply whatever is in there when clicking on a thumbnail and just get rid of the edit mode. Not sure how much stupidity protection the apply mode currently has, but maybe complain when applying an empty tag script.

@ToksT
Copy link
Contributor Author

ToksT commented Apr 25, 2013

I actually had the input field set to disabled when in Apply mode. But I like your idea better.

Also, it already doesn't let you set an empty tag script - if you try to it will revert to the last one you used and change the mode to view.

@ToksT
Copy link
Contributor Author

ToksT commented Apr 25, 2013

Also it auto-saves whatever is in the field whenever you press enter or click outside the field, FYR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants