-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expansion of apply tag script to multiple tag sets #1237
Comments
This would be tremendously helpful. I was about to suggest something similar. I think that the active script should always be visible somewhere on the page (#1009); if it's not, it would be quite easy to forget which you are using. |
Is there a need to limit them at all? It's probably rare to need more than 6 tags in a tag script, but having the ability wouldn't hurt.
Keyboard shortcuts sound like a good idea. But maybe we should also have some sort of UI feedback that you can have multiple tag scripts? I'm not sure where we would put this, though. |
The proper "combobox" control would be perfect for that (the one where you can both type and select a value from list), but sadly neither html nor jquery provide easy ways to do that. How about adding a button with down-arrow next to the tag script input field? So that pressing it would open a list of predefined tag sets, much like autocomplete. |
What would this look/work like exactly? |
Like a combobox control (or |
So like the jquery autocomplete combobox. But the tag script field already has autocomplete, and I don't think two autocompletes on one field would look good. |
Yes, that's why I'm talking about |
Wouldn't it be strange to have two similar-looking autocompletes on one field, regardless of whether one is hand-implemented or not? I don't see what re-implementing it would accomplish other than take up more time. |
I don't understand what's so strange about having two different drop-down lists if they'll never appear at the same time. Regular autocomplete is bound to key type events, stored tag scripts appear only upon pressing the special button at "tag script" mode.There's no need to autocomplete typed things to the stored scripts, it's pretty useless. |
I haven't added a way of changing them with the ui yet, but I added the shortcuts and a notice telling the user when they switch tag scripts and how to do so. |
after browsing the code, i would guess the only intended keys were EDIT: that would be ascii numbers |
Yeah that's a bug. Kind of weird that this would happen, as the code limits it to the 10 number keys pretty straightforwardly: $(document).bind("keypress", "1 2 3 4 5 6 7 8 9 0", Danbooru.PostModeMenu.change_tag_script); It doesn't occur for me when I use Firefox. But I can reproduce this when I use Chrome or Internet Explorer. |
This seems to be a bug with the jquery.hotkeys library. I can reproduce the same bug with a simple html page with just jquery + jquery.hotkeys. |
same here. tested in iceweasel and only the number keys work. though i still find it cool to have 20 tag scripts. |
related issues: #1184 #1199
this is something suggested as an alternative or to be used in parallel for the issues above.
not sure what it's official designation/label/name, but i'm referring to the
tags that the user usually/regularly use for tag gardening
.currently, we can only assign one set of tags when asked on the prompt. you have to edit the tag script for another group of searches losing the previous tag script.
i'm proposing of having multiple tag sets instead of just one. each can be accessed through the keyboard maybe 0..9 when on
edit tag script
mode. the tags can be grouped according to the user's preference maybe maximum of 6 tags each with negations included.this doesn't need to appear on the user's profile nor require additional columns or tables. the tag sets can be stored in a cookie just like the current tag script.
when using
apply tag script
the user can press maybe 0..9 (1 default) to activate his preferred tag set with a notification perhaps on which tags are included. then, he points and presses the mouse pointer to the posts it should apply to.The text was updated successfully, but these errors were encountered: