Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expansion of apply tag script to multiple tag sets #1237

Closed
ghostrigger opened this issue Apr 8, 2013 · 14 comments
Closed

expansion of apply tag script to multiple tag sets #1237

ghostrigger opened this issue Apr 8, 2013 · 14 comments
Labels

Comments

@ghostrigger
Copy link
Contributor

related issues: #1184 #1199

this is something suggested as an alternative or to be used in parallel for the issues above.

not sure what it's official designation/label/name, but i'm referring to the tags that the user usually/regularly use for tag gardening.

currently, we can only assign one set of tags when asked on the prompt. you have to edit the tag script for another group of searches losing the previous tag script.

i'm proposing of having multiple tag sets instead of just one. each can be accessed through the keyboard maybe 0..9 when on edit tag script mode. the tags can be grouped according to the user's preference maybe maximum of 6 tags each with negations included.

this doesn't need to appear on the user's profile nor require additional columns or tables. the tag sets can be stored in a cookie just like the current tag script.

when using apply tag script the user can press maybe 0..9 (1 default) to activate his preferred tag set with a notification perhaps on which tags are included. then, he points and presses the mouse pointer to the posts it should apply to.

@ToksT
Copy link
Contributor

ToksT commented Apr 8, 2013

This would be tremendously helpful. I was about to suggest something similar.

I think that the active script should always be visible somewhere on the page (#1009); if it's not, it would be quite easy to forget which you are using.

@ToksT
Copy link
Contributor

ToksT commented Apr 28, 2013

the tags can be grouped according to the user's preference maybe maximum of 6 tags each with negations included.

Is there a need to limit them at all? It's probably rare to need more than 6 tags in a tag script, but having the ability wouldn't hurt.

each can be accessed through the keyboard maybe 0..9 when on edit tag script mode.
when using apply tag script the user can press maybe 0..9 (1 default) to activate his preferred tag set with a notification perhaps on which tags are included.

Keyboard shortcuts sound like a good idea. But maybe we should also have some sort of UI feedback that you can have multiple tag scripts? I'm not sure where we would put this, though.

@Type-kun
Copy link
Collaborator

But maybe we should also have some sort of UI feedback that you can have multiple tag scripts? I'm not sure where we would put this, though.

The proper "combobox" control would be perfect for that (the one where you can both type and select a value from list), but sadly neither html nor jquery provide easy ways to do that. How about adding a button with down-arrow next to the tag script input field? So that pressing it would open a list of predefined tag sets, much like autocomplete.

@ToksT
Copy link
Contributor

ToksT commented Sep 17, 2013

How about adding a button with down-arrow next to the tag script input field? So that pressing it would open a list of predefined tag sets, much like autocomplete.

What would this look/work like exactly?

@Type-kun
Copy link
Collaborator

Like a combobox control (or <select>) usually does. Except you can't really get "select OR type" functionality by regular html means, so we'd have to hack our way through.

@ToksT
Copy link
Contributor

ToksT commented Sep 18, 2013

So like the jquery autocomplete combobox.

But the tag script field already has autocomplete, and I don't think two autocompletes on one field would look good.

@Type-kun
Copy link
Collaborator

Yes, that's why I'm talking about re-implementing it by hand. Show a predefined list to select from upon pressing the V button.

@ToksT
Copy link
Contributor

ToksT commented Oct 9, 2013

Wouldn't it be strange to have two similar-looking autocompletes on one field, regardless of whether one is hand-implemented or not? I don't see what re-implementing it would accomplish other than take up more time.

@Type-kun
Copy link
Collaborator

Wouldn't it be strange to have two similar-looking autocompletes on one field, regardless of whether one is hand-implemented or not? I don't see what re-implementing it would accomplish other than take up more time.

I don't understand what's so strange about having two different drop-down lists if they'll never appear at the same time. Regular autocomplete is bound to key type events, stored tag scripts appear only upon pressing the special button at "tag script" mode.There's no need to autocomplete typed things to the stored scripts, it's pretty useless.

ToksT added a commit that referenced this issue Oct 11, 2013
@ToksT
Copy link
Contributor

ToksT commented Oct 11, 2013

I haven't added a way of changing them with the ui yet, but I added the shortcuts and a notice telling the user when they switch tag scripts and how to do so.

r888888888 added a commit that referenced this issue Mar 1, 2014
r888888888 added a commit that referenced this issue Mar 1, 2014
@ghostrigger
Copy link
Contributor Author

after browsing the code, i would guess the only intended keys were 1 2 3 4 5 6 7 8 9 0. but i found out (tilde) i e a d f g h c b also work making it 20 possible stored tag scripts in all. i'm not really bothered by it and i don't think it's a bug. thought just need to report it (easter eggs?). i'm using us eng 104-key windows pc keyboard and it works for opera and chromium. i haven't checked in laptop yet if there's complication.

EDIT: that would be ascii numbers 16 17 18 19 20 21 22 23 24 25 and with offset of 80 96 97 98 99 100 101 102 103 104 105

@ToksT
Copy link
Contributor

ToksT commented Apr 10, 2014

after browsing the code, i would guess the only intended keys were 1 2 3 4 5 6 7 8 9 0. but i found out (tilde) i e a d f g h c b also work making it 20 possible stored tag scripts in all.

Yeah that's a bug. Kind of weird that this would happen, as the code limits it to the 10 number keys pretty straightforwardly:

$(document).bind("keypress", "1 2 3 4 5 6 7 8 9 0", Danbooru.PostModeMenu.change_tag_script);

It doesn't occur for me when I use Firefox. But I can reproduce this when I use Chrome or Internet Explorer.

@ToksT
Copy link
Contributor

ToksT commented Apr 10, 2014

This seems to be a bug with the jquery.hotkeys library. I can reproduce the same bug with a simple html page with just jquery + jquery.hotkeys.

@ghostrigger
Copy link
Contributor Author

It doesn't occur for me when I use Firefox.

same here. tested in iceweasel and only the number keys work. though i still find it cool to have 20 tag scripts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants