Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent renaming wikis with non-empty tags. #2964

Closed
evazion opened this issue Apr 6, 2017 · 1 comment
Closed

Prevent renaming wikis with non-empty tags. #2964

evazion opened this issue Apr 6, 2017 · 1 comment

Comments

@evazion
Copy link
Member

evazion commented Apr 6, 2017

From https://danbooru.donmai.us/forum_topics/13868?page=1#forum_post_129247:

If someone renames a wiki that has a non-empty tag, then that tag will still need to be moved and any wikis linking to the old wiki will need to be updated to the new wiki. Therefore there should be a validation that prevents renaming wikis with non-empty tags, to ensure that people fix the tag first. Possibly make it optional like secondary validations on BURs are optional.

@BrokenEagle
Copy link
Collaborator

It goes without saying, but the above should not prevent renames if the tag for the current wiki name is empty, i.e. they have already moved all of the tags to the new name.

evazion added a commit to evazion/danbooru that referenced this issue Apr 10, 2017
evazion added a commit to evazion/danbooru that referenced this issue Apr 10, 2017
r888888888 added a commit that referenced this issue Apr 10, 2017
Fix #2964: prevent renaming wikis with non-empty tags.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants