Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 rg --json input: a highlighted match after a tab is in the wrong position #1441

Closed
th1000s opened this issue Jun 5, 2023 · 2 comments
Closed

🐛 rg --json input: a highlighted match after a tab is in the wrong position #1441

th1000s opened this issue Jun 5, 2023 · 2 comments

Comments

@th1000s
Copy link
Collaborator

th1000s commented Jun 5, 2023

echo -e "\t_abcABC987" >| foo; rg --json ABC98 foo | delta using the current master:

image

It seems the submatches from the json need to take the tabwidth into account.
@th1000s th1000s changed the title 🐛 rg --json input: a highlighted match after a tab is in in the wrong position 🐛 rg --json input: a highlighted match after a tab is in the wrong position Jun 5, 2023
@charego charego mentioned this issue Sep 19, 2023
Merged
@charego
Copy link

charego commented Oct 9, 2023

@dandavison @th1000s I believe this issue can be closed (fixed by #1507).

@dandavison
Copy link
Owner

Yes, that's correct, thanks!

image

@gennaro-tedesco gennaro-tedesco mentioned this issue Dec 25, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dandavison @charego @th1000s