Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support routing with Webix layout #3

Open
ghost opened this issue Feb 19, 2015 · 5 comments
Open

Support routing with Webix layout #3

ghost opened this issue Feb 19, 2015 · 5 comments

Comments

@ghost
Copy link

ghost commented Feb 19, 2015

Hi Dan,

just wanted to let you know that I currently look for a solution for that. I can contribute the solution to this repository if you like.

What I have done:

@dandv
Copy link
Owner

dandv commented Feb 19, 2015

Hi Jonas,

Thanks for the offer to help; PRs would be appreciated.

As for where exactly to contribute the code, I hope that @mkozhukh will help unify the repositories. Right now we have three repos:

My suggestions:

  1. Seems best to have a single repository as the source for the integration, and it seems easiest to merge the Meteor integration code from webix-meteor-example into webix-meteor-data, or even better, directly into this repo, https://github.com/dandv/meteor-webix, because it does packaging according to the Meteor standard. I've already added @mkozhukh as a contributor to this repo, and I'm happy to transfer it into the webix-hub organization. Also, this repo got quite popular (220+ stars, almost 100 watchers - much more popular than Webix itself!) so we should use that to attract more contributors.
  2. That will eliminate the need for https://github.com/dandv/meteor-webix to include https://github.com/webix-hub/webix-meteor-data as a submodule, so the latter repository can be deleted/deprecated and instead we can have just one webix-meteor adapter .js file, with the proxy (now in webix-meteor-data) and Blaze template rendering (now in webix-meteor-example).
  3. This repo already has an example, so we can merge any extra example code from webix-meteor-example into it as well.

@mkozhukh, what do you think?

@ghost
Copy link
Author

ghost commented Feb 19, 2015

I think the pro version of Webix has more features and the additional components (pivot table etc.). I'm not sure if the additional features are stripped out from the webix-hub/tracker repository.

So I would suggest to have a separate Webix wrapper package and one or more additional Webix Meteor integration packages that depend on the Webix wrapper package.
Users of the pro version could clone this wrapper package as local package and replace the webix files with the pro version.

I've done this structure for the current project I work on already:

bildschirmfoto 2015-02-19 um 23 52 25

@mkozhukh Is the https://github.com/webix-hub/webix-meteor-example also under MIT license? The license is missing right now.

@dandv
Copy link
Owner

dandv commented Feb 19, 2015

@sanjo: good point re. the Pro version. This repo is indeed structured to include Webix and the adapter as two submodules, and a Pro user could overwrite webix_debug.js in the webix submodule with the Pro version.

If the webix-meteor proxy adapter needs any extra code for the Pro widgets, that code could still go in the same adapter file, since it will be relatively very small by comparison to the size of the library itself (unless the adapter code somehow needs any part of the Pro version to be already instantiated, which I doubt is the case).

In any case, we can at least unify webix-meteor-data and webix-meteor-example, since the latter includes everything in the former, and fixes the example.

@mkozhukh
Copy link
Collaborator

Seems best to have a single repository as the source for the integration

I'm agree about merging webix-meteor-data and webix-meteor-example in this repo.

Is the https://github.com/webix-hub/webix-meteor-example also under MIT license

Yes. All projects except of main Webix repo are under MIT license. I will update readme files to make it clear.

If the webix-meteor proxy adapter needs any extra code for the Pro widgets

While PRO version has some extra widgets it uses the same code for data loading as GPL version. There will be no need for PRO-related modifications in data-adapter.

@mkozhukh
Copy link
Collaborator

About "routing with Webix layout"

As far as I can see there are two possible solution:

  • "Meteor first" app. In such app main UI is created through Meteor templates. Webix UI is created through templates as well. Updated sample ( https://github.com/webix-hub/webix-meteor-example ) uses this approach. The major disadvantage here that you need to have HTML placeholder for each Webix UI block that seriously limit Webix layout auto-sizing ability.
  • "Webix first" app. I have published example at https://github.com/webix-hub/webix-meteor-mvc. This is a port of mvc layer from webix-adminapp-demo. Instead of using Meteor templates it uses Webix views as main building block. ( you still can use Meteor templates inside of webix views ) Such approach allows to fully utilize the functionality of Webix Layout, but it is quite different from common Meteor app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants