Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 4.0 bugfix #1146

Merged
merged 7 commits into from
May 1, 2023
Merged

Release 4.0 bugfix #1146

merged 7 commits into from
May 1, 2023

Conversation

HaleySchuhl
Copy link
Contributor

Describe your changes
dual threshold bugfix propogated down

Type of update
Is this a:

  • Bug fix
  • New feature or feature enhancement
  • Update to documentation
  • Work in progress

Associated issues
Reference associated issue numbers. Does this pull request close any issues?

Additional context
Add any other context about the problem here.

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Merging #1146 (8e1200f) into release-4.0 (f5da302) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           release-4.0     #1146   +/-   ##
=============================================
  Coverage       100.00%   100.00%           
=============================================
  Files              164       164           
  Lines             7007      7010    +3     
=============================================
+ Hits              7007      7010    +3     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plantcv/plantcv/threshold/threshold_methods.py 100.00% <100.00%> (ø)

@HaleySchuhl HaleySchuhl requested a review from nfahlgren May 1, 2023 15:52
@nfahlgren nfahlgren merged commit d6794a3 into release-4.0 May 1, 2023
5 of 6 checks passed
@nfahlgren nfahlgren deleted the release-4.0-bugfix branch May 1, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants