Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change CHANGELOG.md merge strategy to union #1116

Merged
merged 1 commit into from
Feb 18, 2021

Conversation

rogerluan
Copy link
Contributor

Hey 馃憢

I noticed users are supposed to include changes to CHANGELOG.md on every PR. This causes unnecessary merge conflicts that we could avoid if we changed the merge strategy to "union". What this does is that whenever it finds a merge conflict, it will resolve it automatically by accepting both entries. I believe that's always the case for the CHANGELOG file.

I've been using this in other projects to auto-resolve conflicts of files and it works wonders 馃

For more info: https://git-scm.com/docs/gitattributes

Hope this helps! 馃挭

- This makes CHANGELOG don't conflict as much (or at all).
@danger-public
Copy link

Warnings
鈿狅笍

Please add a changelog entry for your changes. You can find it in CHANGELOG.md

Please add your change and name to the main section.

Generated by 馃毇 dangerJS against 8eecb0b

@orta
Copy link
Member

orta commented Feb 18, 2021

Nice!

@orta orta merged commit 35a98bb into danger:main Feb 18, 2021
@rogerluan
Copy link
Contributor Author

Oh wow that was fast 馃槀 I didn't have time to fix the comment above 馃檲

Cheers!

@rogerluan rogerluan deleted the changelog-union-merge-strategy branch February 18, 2021 14:10
rogerluan added a commit to rogerluan/danger-js that referenced this pull request Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants