Simplify Bitrise repo slug lookup #1115
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey 馃憢
I realized that we had this issue related to Bitrise #1047 and thought it was easy enough to fix. This PR removes
GIT_REPOSITORY_URL
and uses other env vars that are more user friendly to parse, removing the regex completely - which's also safer and now works for all sorts of URLs.With my little understanding of how Danger and CI interacts, I hope that simply and blindly dropping the support to
GIT_REPOSITORY_URL
won't break existing users' setups 馃槵Resolves #1047
Docs: https://devcenter.bitrise.io/builds/available-environment-variables/