Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript support, + danger.d.ts, + danger DSL change #172

Merged
merged 9 commits into from
Mar 19, 2017
Merged

Conversation

orta
Copy link
Member

@orta orta commented Mar 16, 2017

Adds support for dangerfile.ts and uses the Jest config system to handle transformation.


Previous notes:

This PR started small, but had a while to do some work on the trainf, so I programmed away.

This provides the initial basic setup for TypeScript. I added a test but it is way slow, 41 seconds.

So this will fail. The fail does lead to an interesting culprit for why It is slow though:

screen shot 2017-03-16 at 18 02 01

I think when we load up Babel or TypeScript then every JS file is sent through babel including all node_modules - which could definitely slow it down. This is likely something inside the Jest env, that should be pretty easy to track down.

@deecewan
Copy link
Member

I'm assuming that this references #169?

@orta
Copy link
Member Author

orta commented Mar 18, 2017

Yeah #169 mainly, I've used up my computer time for today on #174 - but will probably start going over this again in the next few days

@orta
Copy link
Member Author

orta commented Mar 18, 2017

Note to self, process.execSync can be used to run a child process synchronously. For our Dangerfile.

@orta orta mentioned this pull request Mar 18, 2017
@codecov-io
Copy link

codecov-io commented Mar 18, 2017

Codecov Report

Merging #172 into master will not change coverage.
The diff coverage is 0%.

@@          Coverage Diff          @@
##           master   #172   +/-   ##
=====================================
  Coverage       0%     0%           
=====================================
  Files           3      4    +1     
  Lines          93     96    +3     
  Branches       17     15    -2     
=====================================
- Misses         93     96    +3
Impacted Files Coverage Δ
source/commands/danger-pr.ts 0% <0%> (ø) ⬆️
source/commands/danger-run.ts 0% <0%> (ø) ⬆️
...e/runner/_tests/fixtures/__DangerfileTypeScript.ts 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2a086e...ac25cfc. Read the comment docs.

@orta
Copy link
Member Author

orta commented Mar 18, 2017

Alright, I think this should be good to go from the typescript support side. I'd like reviews around that.

I'd like to continue working on this PR specifically on two things, making Circle CI use a dangerfile.ts and adding a Dangerfile rule about ensuring the d.ts in the repo is completely up to date.

@orta orta force-pushed the bullet-ts branch 2 times, most recently from 35bfc57 to 134d3d4 Compare March 19, 2017 00:03
@orta
Copy link
Member Author

orta commented Mar 19, 2017

OK, the circle CI dangerfile is 👍

Fixes #84

screen shot 2017-03-19 at 09 09 04

@orta
Copy link
Member Author

orta commented Mar 19, 2017

Our current setup makes it possible for the circle ci danger to pass, and to delete the current message on a PR.

This can be fixed by either #162 or the Danger ID thing discussed in #166

@orta orta force-pushed the bullet-ts branch 4 times, most recently from 357d8df to f6c085f Compare March 19, 2017 01:13
@orta orta force-pushed the bullet-ts branch 4 times, most recently from 16f54eb to 977055f Compare March 19, 2017 02:15
@orta
Copy link
Member Author

orta commented Mar 19, 2017

green!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants