-
-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TypeScript support, + danger.d.ts, + danger DSL change #172
Conversation
I'm assuming that this references #169? |
Note to self, process.execSync can be used to run a child process synchronously. For our Dangerfile. |
Codecov Report
@@ Coverage Diff @@
## master #172 +/- ##
=====================================
Coverage 0% 0%
=====================================
Files 3 4 +1
Lines 93 96 +3
Branches 17 15 -2
=====================================
- Misses 93 96 +3
Continue to review full report at Codecov.
|
Alright, I think this should be good to go from the typescript support side. I'd like reviews around that. I'd like to continue working on this PR specifically on two things, making Circle CI use a |
35bfc57
to
134d3d4
Compare
OK, the circle CI dangerfile is 👍 Fixes #84 |
357d8df
to
f6c085f
Compare
16f54eb
to
977055f
Compare
green! |
Adds support for
dangerfile.ts
and uses the Jest config system to handle transformation.Previous notes:
This PR started small, but had a while to do some work on the trainf, so I programmed away.
This provides the initial basic setup for TypeScript. I added a test but it is way slow, 41 seconds.
So this will fail. The fail does lead to an interesting culprit for why It is slow though:
I think when we load up Babel or TypeScript then every JS file is sent through babel including all
node_modules
- which could definitely slow it down. This is likely something inside the Jest env, that should be pretty easy to track down.