Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Text only output + improve wording throughout Danger #183

Merged
merged 5 commits into from
Mar 21, 2017

Conversation

orta
Copy link
Member

@orta orta commented Mar 21, 2017

In #172 I let danger run separately on circle ci. This could delete an existing comment by travis, which is actually doing real work. So this fixes that, and improves the verbose option.

I also tried to run through all of the times when Danger outputs text to the screen to improve the English and provide more info when I can.

@codecov-io
Copy link

codecov-io commented Mar 21, 2017

Codecov Report

Merging #183 into master will not change coverage.
The diff coverage is 0%.

@@          Coverage Diff          @@
##           master   #183   +/-   ##
=====================================
  Coverage       0%     0%           
=====================================
  Files           4      4           
  Lines          96    104    +8     
  Branches       15     16    +1     
=====================================
- Misses         96    104    +8
Impacted Files Coverage Δ
source/commands/danger-pr.ts 0% <ø> (ø) ⬆️
source/commands/danger-run.ts 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52cb834...202ac79. Read the comment docs.

@orta orta merged commit d353bf2 into master Mar 21, 2017
@orta orta deleted the text_output branch March 21, 2017 06:55
@orta
Copy link
Member Author

orta commented Mar 21, 2017

I want some of this stuff for #184

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants