Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inline mode. #529

Merged
merged 41 commits into from
Mar 31, 2018
Merged

Inline mode. #529

merged 41 commits into from
Mar 31, 2018

Commits on Feb 24, 2018

  1. Add file/line options to context violation

    @sunshinejr
    sunshinejr committed Feb 24, 2018
    Configuration menu
    Copy the full SHA
    121c434 View commit details
    Browse the repository at this point in the history

  2. Add fixtures to test validity of file/line results

    @sunshinejr
    sunshinejr committed Feb 24, 2018
    Configuration menu
    Copy the full SHA
    7236c02 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2018

  1. Pass danger DSL to results handler

    @sunshinejr
    sunshinejr committed Feb 25, 2018
    Configuration menu
    Copy the full SHA
    127fa2d View commit details
    Browse the repository at this point in the history

  2. Add createInlineComment to API & platform

    @sunshinejr
    sunshinejr committed Feb 25, 2018
    Configuration menu
    Copy the full SHA
    38ba779 View commit details
    Browse the repository at this point in the history

  3. Fix executor tests

    @sunshinejr
    sunshinejr committed Feb 25, 2018
    Configuration menu
    Copy the full SHA
    2f589e2 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2018

  1. Add inline comment when file/line provided

    @sunshinejr
    sunshinejr committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    379824d View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2018

  1. Add chunks to GitDSL

    @sunshinejr
    sunshinejr committed Mar 3, 2018
    Configuration menu
    Copy the full SHA
    32ca4fa View commit details
    Browse the repository at this point in the history

  2. Move logic for inline comments to platforms

    @sunshinejr
    sunshinejr committed Mar 3, 2018
    Configuration menu
    Copy the full SHA
    333fa3b View commit details
    Browse the repository at this point in the history

  3. Calculate position for inline comment in a platform

    @sunshinejr
    sunshinejr committed Mar 3, 2018
    Configuration menu
    Copy the full SHA
    ca53349 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2018

  1. Markdown as Violation as well

    @sunshinejr
    sunshinejr committed Mar 4, 2018
    Configuration menu
    Copy the full SHA
    77bfe7a View commit details
    Browse the repository at this point in the history

  2. Better Promises & test fixes

    @sunshinejr
    sunshinejr committed Mar 4, 2018
    Configuration menu
    Copy the full SHA
    8057059 View commit details
    Browse the repository at this point in the history

  3. DangerResults updates & tests

    @sunshinejr
    sunshinejr committed Mar 4, 2018
    Configuration menu
    Copy the full SHA
    f155b46 View commit details
    Browse the repository at this point in the history

  4. Fix for dts creator to skip _tests directory

    @sunshinejr
    sunshinejr committed Mar 4, 2018
    Configuration menu
    Copy the full SHA
    13d7268 View commit details
    Browse the repository at this point in the history

  5. Inline comments returning results test

    @sunshinejr
    sunshinejr committed Mar 4, 2018
    Configuration menu
    Copy the full SHA
    e7a3191 View commit details
    Browse the repository at this point in the history

  6. GithubAPI postInlinePRComment tests

    @sunshinejr
    sunshinejr committed Mar 4, 2018
    Configuration menu
    Copy the full SHA
    8e433b6 View commit details
    Browse the repository at this point in the history

  7. Merge remote-tracking branch 'original/azz-bitbucket-server' into fil… 

    …e_line_api

# Conflicts:
#	source/platforms/GitHub.ts
#	source/runner/Executor.ts
    @sunshinejr
    sunshinejr committed Mar 4, 2018
    Configuration menu
    Copy the full SHA
    57a5db5 View commit details
    Browse the repository at this point in the history

  8. Fix Bitbucket tests & platform conformation

    @sunshinejr
    sunshinejr committed Mar 4, 2018
    Configuration menu
    Copy the full SHA
    438c2e2 View commit details
    Browse the repository at this point in the history

  9. Some code cleanup

    @sunshinejr
    sunshinejr committed Mar 4, 2018
    Configuration menu
    Copy the full SHA
    26ec065 View commit details
    Browse the repository at this point in the history

  10. Fix fixtures

    @sunshinejr
    sunshinejr committed Mar 4, 2018
    Configuration menu
    Copy the full SHA
    b6f9054 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2018

  1. Improve inline comment message

    @sunshinejr
    sunshinejr committed Mar 6, 2018
    Configuration menu
    Copy the full SHA
    2b32cdb View commit details
    Browse the repository at this point in the history

  2. More comments around functions & enforce both file and line for inlin… 

    …e violation
    @sunshinejr
    sunshinejr committed Mar 6, 2018
    Configuration menu
    Copy the full SHA
    37dfc32 View commit details
    Browse the repository at this point in the history

  3. Add BitbucketServer inline comment template as well

    @sunshinejr
    sunshinejr committed Mar 6, 2018
    Configuration menu
    Copy the full SHA
    4c44daa View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2018

  1. Add sorting inline results

    @sunshinejr
    sunshinejr committed Mar 7, 2018
    Configuration menu
    Copy the full SHA
    dc3363e View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2018

  1. Add sort inline results snapshot tests

    @sunshinejr
    sunshinejr committed Mar 8, 2018
    Configuration menu
    Copy the full SHA
    643a43b View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2018

  1. Include file/line of inline violation in main comment

    @sunshinejr
    sunshinejr committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    a5efed8 View commit details
    Browse the repository at this point in the history

  2. Update inline comment in main comment formating

    @sunshinejr
    sunshinejr committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    fce9163 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2018

  1. API & platform & test for getting/deleting inline comments

    @sunshinejr
    sunshinejr committed Mar 16, 2018
    Configuration menu
    Copy the full SHA
    c9c3d52 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2018

  1. First version of updating inline comments

    @sunshinejr
    sunshinejr committed Mar 17, 2018
    Configuration menu
    Copy the full SHA
    26dcf50 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2018

  1. Test for updating/creating inline comments

    @sunshinejr
    sunshinejr committed Mar 18, 2018
    Configuration menu
    Copy the full SHA
    d3eadca View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'original/master' into file_line_api

    @sunshinejr
    sunshinejr committed Mar 18, 2018
    Configuration menu
    Copy the full SHA
    c13ecb7 View commit details
    Browse the repository at this point in the history

  3. Delete inline comments handling

    @sunshinejr
    sunshinejr committed Mar 18, 2018
    Configuration menu
    Copy the full SHA
    1c38bb1 View commit details
    Browse the repository at this point in the history

  4. Refactor chunks into StructuredDiff

    @sunshinejr
    sunshinejr committed Mar 18, 2018
    Configuration menu
    Copy the full SHA
    d2b2315 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2018

  1. Adds changelog + some light docs

    @orta
    orta committed Mar 26, 2018
    Configuration menu
    Copy the full SHA
    484671d View commit details
    Browse the repository at this point in the history

  2. Merge master

    @orta
    orta committed Mar 26, 2018
    Configuration menu
    Copy the full SHA
    73e49bd View commit details
    Browse the repository at this point in the history

  3. Pass the danger ID along

    @orta
    orta committed Mar 26, 2018
    Configuration menu
    Copy the full SHA
    674610b View commit details
    Browse the repository at this point in the history

  4. Test out the inline on danger

    @orta
    orta committed Mar 26, 2018
    Configuration menu
    Copy the full SHA
    b1ce78c View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2018

  1. Update repo slug for GithubAPI to be a base instead of pr

    @sunshinejr
    sunshinejr committed Mar 27, 2018
    Configuration menu
    Copy the full SHA
    62ad270 View commit details
    Browse the repository at this point in the history

  2. Add logging for inline comments

    @sunshinejr
    sunshinejr committed Mar 27, 2018
    Configuration menu
    Copy the full SHA
    5fc6d66 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2018

  1. Remove the testing inline messages

    @orta
    orta committed Mar 31, 2018
    Configuration menu
    Copy the full SHA
    1499ed6 View commit details
    Browse the repository at this point in the history

  2. Convert console.logs to debug

    @orta
    orta committed Mar 31, 2018
    Configuration menu
    Copy the full SHA
    dd7ed3b View commit details
    Browse the repository at this point in the history

  3. Remove some console logs

    @orta
    orta committed Mar 31, 2018
    Configuration menu
    Copy the full SHA
    8b72d0f View commit details
    Browse the repository at this point in the history