Handle more events than just pull_request #940
Conversation
| return this.event.pull_request.number | ||
| } else if (this.event.issue !== undefined) { | ||
| return this.event.issue.number |
There was a problem hiding this comment.
This part is a little bit controversial, I've added it because technically the PR is a particular type of issue, and then I was thinking to someone that wants to run danger when a pr comment is added, and in that case I think he would have to use issue_comment, pull_request_review and pull_request_review_comment triggers.
(An example of that could be verify that there are no open tasks on the comments
like
- Remove this commented code
)
In issue_comment there is no pull request JSON, only the issue one https://developer.github.com/v3/activity/events/types/#webhook-payload-example-14
There was a problem hiding this comment.
Happy to remove it if is a bad idea
There was a problem hiding this comment.
I'm open to seeing where this goes 👍
|
@orta looks like one of the build failed, but just needs to be restarted. |
|
cool! |
|
Thank you @orta :) |
|
alright, let's go then |
With GitHub actions you can have more events in the PR than just the simple
pull_requestone, like for examplepull_request_revieworpull_request_review_comment