Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds gitlab docs #962

Merged
merged 1 commit into from
Nov 27, 2019
Merged

Adds gitlab docs #962

merged 1 commit into from
Nov 27, 2019

Conversation

orta
Copy link
Member

@orta orta commented Nov 27, 2019

I've not run through this myself, but it looks about right

@orta orta merged commit 6ae125d into master Nov 27, 2019
@f-meloni
Copy link
Member

I think I should do the same for Danger-Swift

@orta
Copy link
Member Author

orta commented Nov 27, 2019

👍

Copy link

@sluongng sluongng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wording should also make it clear that this is about gitlab as a Git Provider platform so its not to be confused with Gitlab-CI which is a CI provider platform.

/** The pull request and repository metadata */
metadata: RepoMetaData
/** The Merge Request metadata */
mr: BitBucketCloudPRDSL
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was BitBucket referenced here?

/** The Merge Request metadata */
mr: BitBucketCloudPRDSL
/** The commits associated with the merge request */
commits: BitBucketCloudCommit[]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BitBucket should not be mentioned here?

```ts
import { danger, warn } from "danger"

if (danger.bitbucket_cloud.mr.title.includes("WIP")) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be danger.gitlab instead

@orta
Copy link
Member Author

orta commented Dec 7, 2019

Nice feedback, happy to take some PRs on it 👍

@sluongng
Copy link

sluongng commented Dec 8, 2019

Nice feedback, happy to take some PRs on it 👍

Tried to fix it in #966

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants