-
-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds gitlab docs #962
Adds gitlab docs #962
Conversation
I think I should do the same for Danger-Swift |
👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The wording should also make it clear that this is about gitlab as a Git Provider platform so its not to be confused with Gitlab-CI which is a CI provider platform.
/** The pull request and repository metadata */ | ||
metadata: RepoMetaData | ||
/** The Merge Request metadata */ | ||
mr: BitBucketCloudPRDSL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was BitBucket referenced here?
/** The Merge Request metadata */ | ||
mr: BitBucketCloudPRDSL | ||
/** The commits associated with the merge request */ | ||
commits: BitBucketCloudCommit[] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BitBucket should not be mentioned here?
```ts | ||
import { danger, warn } from "danger" | ||
|
||
if (danger.bitbucket_cloud.mr.title.includes("WIP")) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be danger.gitlab
instead
Nice feedback, happy to take some PRs on it 👍 |
Tried to fix it in #966 |
I've not run through this myself, but it looks about right