Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved gitlab documentation #966

Merged
merged 1 commit into from
Dec 10, 2019
Merged

Improved gitlab documentation #966

merged 1 commit into from
Dec 10, 2019

Conversation

sluongng
Copy link

@sluongng sluongng commented Dec 7, 2019

  • Fixed some Bitbucket references in Gitlab doc
  • Added commitHash() onto Gitlab CI platform

@sluongng sluongng mentioned this pull request Dec 8, 2019
Merged
@sluongng
Copy link
Author

sluongng commented Dec 8, 2019 •
edited
Loading

Not sure why CI is failing (Travis being flaky?)

Regardless, this is mostly a documentation change so should have no impact

@orta could you please take a look

@orta
Copy link
Member

orta commented Dec 10, 2019

Great1 Thanks, yeah, travis is having caching problems for some reason

@orta orta merged commit 4f12214 into danger:master Dec 10, 2019
@peril-staging
Copy link
Contributor

peril-staging bot commented Jan 5, 2020

Thanks for the PR @sluongng.

This PR has been shipped in v9.2.10 - CHANGELOG.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sluongng @orta