Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a timeout for waiting to STDIN? #108

Closed
orta opened this issue Nov 15, 2018 · 4 comments
Closed

Add a timeout for waiting to STDIN? #108

orta opened this issue Nov 15, 2018 · 4 comments

Comments

@orta
Copy link
Member

orta commented Nov 15, 2018

Still trying to figure out why builds like https://travis-ci.org/danger/swift/jobs/455599717 are failing, maybe it's because STDOUT isn't being read and we're blocking on waiting for that? Danger JS is definitely sending it.
@orta
Copy link
Member Author

orta commented Nov 20, 2018

I could see this, if it takes under a few ms to compile the package.swift etc the delay on listening out for STDIN could take too long.

This was referenced Nov 20, 2018
Closed
Merged
@orta
Copy link
Member Author

orta commented Nov 20, 2018

danger-js should now be able to send the DSL down, will just need to add a timeout and ship it in danger/swift

@orta
Copy link
Member Author

orta commented Dec 15, 2018

This is #108

@orta orta closed this as completed Dec 15, 2018
@orta
Copy link
Member Author

orta commented Dec 15, 2018

Actually
#97

@orta orta mentioned this issue Dec 16, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@orta