Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upComments
This comment has been minimized.
This comment has been minimized.
|
I could see this, if it takes under a few ms to compile the package.swift etc the delay on listening out for STDIN could take too long. |
This was referenced Nov 20, 2018
This comment has been minimized.
This comment has been minimized.
|
danger-js should now be able to send the DSL down, will just need to add a timeout and ship it in danger/swift |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
orta commentedNov 15, 2018
Still trying to figure out why builds like https://travis-ci.org/danger/swift/jobs/455599717 are failing, maybe it's because STDOUT isn't being read and we're blocking on waiting for that? Danger JS is definitely sending it.