allow editing/unhiding by group

[farodin91]

Fixes #2989

[BlackDex]

Thanks for the contribution.

I'm not sure if i like the way this is build. Running multiple queries and using matches is a bit counter productive and slows everything down. I would rather have just one query run which returns all the correct info.

I actually think we need to change the schema's of the group-tables to be less normalized to make queries a bit more nice and quicker. I haven't had the time yet to look at it. While this is a patch, i would rather have a better fix.
Also for all the other queries which currently are getting very complex with all the joins because how far normalized the tables are.

[farodin91]

I wanted to fix and saw some other query's that are huge. I find it hard to debug query's that have multiple joins. This way you can reuse some code. The location is probably wrong, I will fix this it by moving directly into collections.

[BlackDex]

Still, running multiple queries for just one output and checking everything code-side makes it more complex in the end.

The multiple joins is the pain i also want to fix by changing the schema in some way which is a better fit for our usage.
But that doesn't grant calling multiple separate queries and trying to join them our selfs i think. It could also cause some weird race conditions in this case, if for some strange reason the first queries retrieved unmatchable info compared to the second for example. While the chance is small, it does exists.

[farodin91]

@BlackDex I changed it to one query by using find_by_uuid_and_user.

[BlackDex]

While I'm still in favor of changing the DB Schema around the whole group handling to make it less complex, probably with a bit less of normalization, this quick fix does provide a good way of allowing this feature to be tested a bit further by more people and give us time to think about a proper and better solution.

So, ill approve this PR, with the side note that i think we do need to rework this feature to be less complex.

[BlackDex]

@farodin91 Could you try to rebase 😄 .

[farodin91]

@BlackDex Rebased.

Do i have write in the discussion for re license thread?

[BlackDex]

@BlackDex Rebased.

Do i have write in the discussion for re license thread?

That would be nice :)

[bendem]

Awesome, and thank you for favoring performance. It is indeed a bit harder to read, but users and database admins thank you for it (re #1402).