Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme for docker hub #64

Merged
merged 1 commit into from Jul 8, 2018
Merged

Conversation

mprasil
Copy link
Contributor

@mprasil mprasil commented Jul 8, 2018

Hi, as per our discussion at #62 this is a PR to merge in the README changes. I think most of the information should be preserved, some of it is moved into separate BUILD.md file.

As for the docker hub side of things, if you're interested, create an account there and let me know, I can add you as collaborator, this should hopefully make things easier in the future. If you're not interested having yet another account in your bitwarden Valut, that's fine, but we need to figure out how can we get in touch to set up build trigger so that the whole thing is automated. (email me at miroslav@prasil.info perhaps?)

@dani-garcia
Copy link
Owner

Alright, I've created a Docker Hub account, at https://hub.docker.com/u/danigarcia/.

I'll merge this now, thanks.

@dani-garcia dani-garcia merged commit c5dd1a0 into dani-garcia:master Jul 8, 2018
@mprasil
Copy link
Contributor Author

mprasil commented Jul 8, 2018

Added you as a collaborator on the repository. Hopefully you can see the Build Setting now. If you scroll down, you should see build trigger, just add that as a webhook in the github repo settings and see if you can trigger a build this way. Once that's done, this should trigger a build when there's a git push.

@mprasil
Copy link
Contributor Author

mprasil commented Jul 8, 2018

I'm still trying to move the source repository path, so maybe wait a bit until that's done. I'll let you know.

@mprasil
Copy link
Contributor Author

mprasil commented Jul 8, 2018

Actually I'm afraid that I can't change the source to your repository as I'm not owner or collaborator here. Can you follow the steps here to try and setup the trigger?

@dani-garcia
Copy link
Owner

I've tried that, but that means creating a new image under my name. I've also tried accessing the build settings for your image but apparently collaborators don't have access to that.

The way I see it is we have three options:

  • I'll mark you as collaborator here (I'm fine with it if you are too) and hope that it's enough to change the source repo. Then I'll probably have to set-up the webhook to build on git push and then the image should be automated.
  • You continue as before, pulling the changes here to your repo, which should be easier now. This would mean no automation, but this proyect doesn't receive important changes that often, so it woudn't be that problematic.
  • I create an automated image under my name, and you modify the README of yours to indicate the users to migrate to the new one. This would require action by the users, but as both images are practically the same, the migration shouldn't be complicated.

@mprasil
Copy link
Contributor Author

mprasil commented Jul 8, 2018

Man I'd be honoured to be contributor on this project. If you want to go ahead with this, I'm definitely interested. Let's hope that will be enough to change the source repo. (I think it should be)

If that won't work, then I'd rather do pulls manually.

From my experience changing the Readme doesn't really work to redirect people as most will only see it once and then they just use the image. Case in point is my other bitwarden-ruby image which I created as an test image from one of the forks of the ruby API implementation. It raked in 10k+ downloads in days which definitely surprised me (being an non-automatic build from non-main branch code and all that..) but I had no intentions keeping it alive long-term really. I tried to redirect people in Readme and it just doesn't work. That ruby thing is still being downloaded despite the warning and no updates for long time.. (I plan to eventually remove it which might make some of the users look at the Readme, but at that stage you're essentially breaking people's setup)

@dani-garcia
Copy link
Owner

Alright, I've invited you. Hopefully that's enough to solve the problem.
You are now officially a collaborator of the proyect! 🎉

@mprasil
Copy link
Contributor Author

mprasil commented Jul 8, 2018

🎊 🎆 Yay, I think I should celebrate. 🍷

But the bad news is I still can't setup the repository to do the automated build. I guess as long as I don't have access to repository settings, it won't give me that option. (It for example adds deploy read-only ssh key, which I definitely can't do here) But no worries I can sync the repo manually for now, now that the readme is merged it's not much work and I can eventually automate the sync.

thelittlefireman pushed a commit to thelittlefireman/bitwarden_rs that referenced this pull request Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants