Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offical Docker Hub image #62

Closed
jkaberg opened this issue Jul 7, 2018 · 3 comments
Closed

Offical Docker Hub image #62

jkaberg opened this issue Jul 7, 2018 · 3 comments

Comments

@jkaberg
Copy link
Contributor

jkaberg commented Jul 7, 2018

Would you please setup an automated build for bitwarden_rs @ Docker Hub?

Documentation found here

Thanks for the hard work you put into this 😄

@mprasil
Copy link
Contributor

mprasil commented Jul 7, 2018

Hi @jkaberg, you can use my image if you'd like. It's automated build based on top of this source code, the only difference is docker hub focused README. (Just a commit I rebase on top of latest changes in this repo)

@dani-garcia the linked hub image accumulated quite a lot of users (to my surprise really) not sure what to do with it at this stage. I don't want to just discontinue it (I'm using it as well) and I don't mind maintaining it at all, but if you like I can give you access there or something to make it "official" and to give you some control over it if you're interested.

Whatever you prefer really as long as it's not confusing for current and future users.

@dani-garcia
Copy link
Owner

@mprasil personally I'm indifferent about it. If you want, you can PR the changes to the README to avoid having to rebase it every time and we can call your version the official.

I'm not sure how Docker Hub works, but if we do that maybe you can point your image to this repository directly and avoid having to use a fork to pull the changes? That way it would be completely automated and save you time.

You are right that now that people are using your image we simply can't take it down.

@mprasil
Copy link
Contributor

mprasil commented Jul 9, 2018

So to sum up, the official image is available here. This is now following the upstream source code. I think we can close this now.

@mprasil mprasil closed this as completed Jul 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants