Fixed 'accept' attribute documentation #431
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added description about valid 'accept' parameter values: don't mix file types and mime types in an accept attribute value!
danialfarid
pushed a commit
that referenced
this pull request
Dec 5, 2014
|
Updated the doc to reflect this, for ng-file-drop it doesn't need to be complaint with HTML accept attribute. |
|
Allright, cool! 👍 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added description about valid 'accept' parameter values: don't mix file types and mime types in an accept attribute value!
Current examples (upload images / pdfs) don't work due to mixed mime type / file extension definition in
acceptattribute.See spec definition here: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Input#attr-accept
It's not literally stating that mixing values for
acceptis a wrong thing to do but tests using this directive prove that it only works when you either list mime types or file extensions. Not both.