Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganising #46

Merged
merged 134 commits into from
Nov 7, 2017
Merged

Reorganising #46

merged 134 commits into from
Nov 7, 2017

Conversation

daniel1noble
Copy link
Owner

No description provided.

joelpick and others added 30 commits October 25, 2017 15:34
…thing calls internal_redraw for plotting, so code is not repeated everywhere. broke down big functions into lots of small functions
…Also simplified arguments for scatter and histograms
…Mean_error / box plot doesn’t really work yet with edit (it makes you redo it…) but histogram and scatterplot should be working - but needs testing
…ne in getNotdoneFiles..created new function dir_details
@codecov
Copy link

codecov bot commented Nov 7, 2017

Codecov Report

Merging #46 into master will increase coverage by 32.86%.
The diff coverage is 34.67%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #46       +/-   ##
===========================================
+ Coverage    3.95%   36.82%   +32.86%     
===========================================
  Files          11       14        +3     
  Lines         506      774      +268     
===========================================
+ Hits           20      285      +265     
- Misses        486      489        +3
Impacted Files Coverage Δ
R/transformStats.R 100% <ø> (+42.85%) ⬆️
R/S_extract.R 0% <0%> (ø) ⬆️
R/H_extract.R 0% <0%> (ø) ⬆️
R/edit_metaDigitise.R 0% <0%> (ø)
R/ME_Box_extraction.R 0% <0%> (ø) ⬆️
R/redraw.R 0% <0%> (ø) ⬆️
R/graph_rotation.R 100% <100%> (+100%) ⬆️
R/calibrate_coords.R 38.98% <100%> (+38.98%) ⬆️
R/conversion.R 100% <100%> (ø)
R/point_extraction.R 100% <100%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8879437...97e345f. Read the comment docs.

@codecov
Copy link

codecov bot commented Nov 7, 2017

Codecov Report

Merging #46 into master will increase coverage by 32.86%.
The diff coverage is 34.67%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #46       +/-   ##
===========================================
+ Coverage    3.95%   36.82%   +32.86%     
===========================================
  Files          11       14        +3     
  Lines         506      774      +268     
===========================================
+ Hits           20      285      +265     
- Misses        486      489        +3
Impacted Files Coverage Δ
R/transformStats.R 100% <ø> (+42.85%) ⬆️
R/H_extract.R 0% <0%> (ø) ⬆️
R/ME_Box_extraction.R 0% <0%> (ø) ⬆️
R/S_extract.R 0% <0%> (ø) ⬆️
R/edit_metaDigitise.R 0% <0%> (ø)
R/redraw.R 0% <0%> (ø) ⬆️
R/graph_rotation.R 100% <100%> (+100%) ⬆️
R/point_extraction.R 100% <100%> (ø)
R/calibrate_coords.R 38.98% <100%> (+38.98%) ⬆️
R/conversion.R 100% <100%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8879437...97e345f. Read the comment docs.

@daniel1noble daniel1noble merged commit f2ee8ce into master Nov 7, 2017
@daniel1noble
Copy link
Owner Author

Merged in development branch to master @joelpick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants