Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve live example by replacing all window.alerts by toasts or other non blocking alerts #241

Closed
danielcaldas opened this issue Oct 1, 2019 · 1 comment
Assignees
Labels
documentation add documentation to the repository or the the code base feature request Hacktoberfest Hacktoberfest label

Comments

@danielcaldas
Copy link
Owner

Is your feature request related to a problem? Please describe.
Currently, there are a few window.alert usages in the live example that might be a bit annoying for the end-user because although in fact an action was performed, it does not mean that we need to interrupt the browser.

Describe the solution you'd like
Provide the interaction example messages in a nonblocking notification component such as a toast or a notification banner. A good candidate for this kind of use case is fkhadra/react-toastify, but others might come into play.

Describe your use case
User clicks on some link, informative toast is display for demonstration purposes.

Describe alternatives you've considered
fkhadra/react-toastify

Additional context
This is ugly.

image

@danielcaldas danielcaldas added feature request Hacktoberfest Hacktoberfest label documentation add documentation to the repository or the the code base labels Oct 1, 2019
@danielcaldas danielcaldas self-assigned this Oct 1, 2019
@danielcaldas
Copy link
Owner Author

Closing this with #244, no lib dist affect. New sandbox bundle released with #244. The new sandbox version is live.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation add documentation to the repository or the the code base feature request Hacktoberfest Hacktoberfest label
Projects
None yet
Development

No branches or pull requests

1 participant