Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collapsible node with no links errors out on click #292

Closed
vsramanujan opened this issue Jan 18, 2020 · 1 comment · Fixed by #293
Closed

Collapsible node with no links errors out on click #292

vsramanujan opened this issue Jan 18, 2020 · 1 comment · Fixed by #293
Labels
bug priority high

Comments

@vsramanujan
Copy link

vsramanujan commented Jan 18, 2020 •
edited
Loading

Describe the bug
Orphan nodes that are collapsible error out on click

To Reproduce
Steps to reproduce the behavior:

  1. Go to the live demo page
  2. Enable the collapsible property
  3. Keep removing nodes until there are no links in the graph
  4. Click on any of the nodes to trigger the collapse behaviour
  5. Voila - uncaught TypeError in the console

Expected behavior
Do nothing - but not error out

Screenshots

Screenshot 2020-01-18 at 2 15 06 PM
@vsramanujan vsramanujan mentioned this issue Jan 18, 2020
Merged
@vsramanujan vsramanujan changed the title Graph with collapsible prop errors when it has only nodes and no links Collapsible node with no links errors out on click Jan 18, 2020
@danielcaldas
Copy link
Owner

Thanks for the detailed description and the PR @vsramanujan 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug priority high
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix error on collapse for node with no links vsramanujan/react-d3-graph
2 participants
@danielcaldas @vsramanujan