Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How can I build/test Sulla #47

Closed
sberlati opened this issue Aug 2, 2019 · 3 comments
Closed

How can I build/test Sulla #47

sberlati opened this issue Aug 2, 2019 · 3 comments

Comments

@sberlati
Copy link

sberlati commented Aug 2, 2019

Hi!
I'm trying to contribute by adding features to the project (like sending messages to an ID, etc) but I can't find the way to test it.

I forked the project, run npm install, made the modifications, and then npm run-script build, so the dist folder is generated.

I've also created a "testing" project where I use npm install [sulla_local_path]. The problem is when I run the test project, I get:

UnhandledPromiseRejectionWarning: TypeError: puppeteer.launch is not a function
    at C:\nodeprojects\sulla\dist\controllers\browser.js:96:46
    at step (C:\nodeprojects\sulla\dist\controllers\browser.js:32:23)
    at Object.next (C:\nodeprojects\sulla\dist\controllers\browser.js:13:53)
    at C:\nodeprojects\sulla\dist\controllers\browser.js:7:71
    at new Promise (<anonymous>)
    at __awaiter (C:\nodeprojects\sulla\dist\controllers\browser.js:3:12)
    at initBrowser (C:\nodeprojects\sulla\dist\controllers\browser.js:92:12)
    at Object.<anonymous> (C:\nodeprojects\sulla\dist\controllers\browser.js:53:36)
    at step (C:\nodeprojects\sulla\dist\controllers\browser.js:32:23)
    at Object.next (C:\nodeprojects\sulla\dist\controllers\browser.js:13:53)
(node:10176) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 2)
(node:10176) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

I check in my testing project node_modules folder and there is the puppeteer and sulla folder.

What steps am I missing?
Thanks for this project! And sorry for the bad english.

Greetings

@beeeku
Copy link

beeeku commented Aug 2, 2019

I guess this error will be fixed in this pull request #48

@sberlati
Copy link
Author

sberlati commented Aug 4, 2019

That worked perfectly, thanks @beeeku !

@sberlati sberlati closed this as completed Aug 4, 2019
@danielcardeenas
Copy link
Owner

danielcardeenas commented Jan 24, 2020

Clone the repo

> npm run build
> npm run start

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants