Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaks mobx #4

Closed
mrjjwright opened this issue Jan 21, 2017 · 3 comments
Closed

Breaks mobx #4

mrjjwright opened this issue Jan 21, 2017 · 3 comments

Comments

@mrjjwright
Copy link

After yarn install this package, mobx observation stops working in my project. Deleting the dependency on bidi-mobx in my package.json, and running yarn install and a webpack build again causes it to start working again. I tested several times, just changing my dependency on bidi-mobx, without actually using it. This must be a webpack build thing.

@mrjjwright
Copy link
Author

I thinking I am making a rookie mistake and not using mobx as an external so it's not loaded twice.

See mobxjs/mobx#763.

Going to try to fix this and report back.

@mrjjwright
Copy link
Author

Yep, using mobx as an external in webpack fixed this.

@danielearwicker
Copy link
Owner

Thanks, looks like I missed all the excitement. I will note this in the readme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants