Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider dropping separate *Fmt calls for overloading them #17

Closed
TommiPrami opened this issue Mar 19, 2018 · 2 comments
Closed

Consider dropping separate *Fmt calls for overloading them #17

TommiPrami opened this issue Mar 19, 2018 · 2 comments
Assignees
Labels
accepted Issue has been accepted and inserted in a future milestone enhancement
Milestone

Comments

@TommiPrami
Copy link
Contributor

I think it would be easier to just have two overloaded calls with different set of parameters, so it would be faster to switch between the two if needed.

@danieleteti
Copy link
Owner

We considered this is some meetings, however we think that the Fmt version is more "delphi like" because it is similar to the .Create and. CreateFmt of the Exception class.
However, we could just add the overload without break the retrocompatibility... we take it in consideration. Thank you for your suggestion.

@danieleteti danieleteti added this to the milestone_1_3_0 milestone May 23, 2018
@TommiPrami
Copy link
Contributor Author

I thought the logic was from exception class. I think that is remainder from the time there was no method overloading.

Either way it is not such a big deal, I happen to like overloads more, in case s like this.

@danieleteti danieleteti added the accepted Issue has been accepted and inserted in a future milestone label Aug 10, 2018
@danieleteti danieleteti self-assigned this Aug 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Issue has been accepted and inserted in a future milestone enhancement
Projects
None yet
Development

No branches or pull requests

2 participants