Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(high): load schema.Examples into []any #21

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

danielgtaylor
Copy link
Contributor

It looks like the schema.Examples field was missed when loading the high-level schema from a low-level one. This adds it along with a test. It allocates a new slice because we want to go from the low-level model to just the values in a []any.

Part of danielgtaylor/restish#115

Copy link
Member

@daveshanley daveshanley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@daveshanley daveshanley merged commit f72cd13 into pb33f:main Nov 29, 2022
@daveshanley
Copy link
Member

Nice! I knew there would be a few of these missing in places. Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants