-
-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ASAMMDF GUI v7.1.1 GPS Map Not Displaying #751
Comments
There seems to be a bug if PySide6==6.3.1 is used. |
Correct Daniel, this solves it on my end with the latest dev version and forcing |
Hi again, After some more digging, I have found out that using However, using that version of PySide6 also unfortunately causes the Bus Logging tabular display and CAN bus trace views to "crash" if I click a cell/row, as mentioned in another issue. In contrast, using Not sure why |
@MartinF PySide6 6.2.4 is also available. Do you get the crash with this version as well? |
I don't get the crash with 6.2.4, but with that version the GPS map does not work unfortunately. Below are my current dependencies related to this:
|
Here is the error output by the way:
|
Some additional inputs: When using However, if I DBC decode the data and then try to use the 'tabular display' to show data for a Channel Group, I can select cells without causing the crash. This leads me to believe the issue with |
One additional update on this: After some more testing, it appears the issue is not necessarily linked to Bus Logging vs. Decoded data. Rather, it appears to be an issue related to the size of the file. If I wait for a very extended period of time, I am able to select cells across any files. I.e. to clarify, there is not a "crash" per se, but rather some very heavy and extended processing that appears to take place when I click a cell for the first time. The processing time is linked to the amount of data in the Channel Group, which also explains why the issue may at first appear more prevalent for Bus Logging (where all CAN data is in the same Channel Group), vs. e.g. a decoded CAN ID Channel Group. In short, the "bug" appears to be some excessive processing that is initiated when a cell is clicked while using |
@MatinF can you send the file that shows this delay? |
@danielhrisca Please see attached below examples. To clarify, this is not related to a specific MF4 file - it happens across all our log files (unfinalized, finalized). The 'stalling' is directly related to the file size and my hypothesis is that there is some 'unintended' refresh/reload of the entire dataset when a cell is clicked. What is surprising, perhaps, is that this "refresh issue" takes far longer than loading the file and loading the CAN bus trace. With the small file With the larger file, During the stalling, asammdf is competely unresponsive and my PC sounds as if it's doing some intensive work. |
Also, if there is any console print output I can provide that may help clarify this let me know. The default console does not seem to yield info directly related to the clicking of a cell. best, |
One extra update: It appears that after the "loading/stalling" is done, I am able to freely select cells for a while. But if I change tabs (e.g. to my browser and back again), it seemingly has to again go through the "loading" process, causing the stalling again. |
|
So I tried the below steps:
In this setup, the "cell loading" issue does not exist, but the GPS plot also does not work. This is expected as the default dependency requirement for asammdf is as per below: Pip freeze for default installation in virtual environment
Pip freeze after changing to PySide6==6.2.0
Other things I tried
The issue seems to be linked to Cell loading fixed (but no GPS map)
Cell loading not fixed (but GPS map works)
|
I'm sorry Martin, I get no slowdown with a new environment and this pip freeze:
|
Hi again Daniel, can you let me know what OS environment you're testing this on? Maybe we can replicate your setup on our end on a Linux PC and see if we then find an issue or not. |
Windows 10 x64, cpython 3.10 x64 |
Hi again Daniel, So I upgraded from Python 3.8 to Python 3.10 (x64, like my Windows 10 x64), installed via the Windows Installer from here: I then did a virtual environment and installed your dependencies (and double checked that they match exactly yours). But the issue persists. I've recorded a video of it below and attached the sample file I'm loading. asammdf-issue.mp4I simply do not understand why this would differ. |
As an additional observation: In my virtual environment, I'm able to install asammdf 7.0.7, which I believe is the "latest" version that allows me to both click around cells without issues in the tabular display or CAN bus trace - while also supporting the GPS map. All works with below dependencies:
However, we would of course want to get it working also with the more recent asammdf releases. If I use the above dependencies and update to asammdf 1.0.1, it reintroduces the issue with clicking cells causing loading. |
Another from my team tested this and on his PC it works OK. So it may be something specific to my PC, though I have no idea what it might be .. |
Suggest closing this as it appears to be something specific to my PC |
With the latest release 7.3.16 running pip install asammdf[gui] will install the correct pinned version and multiple GPS windows are working |
Python version
('python=3.9.13 (tags/v3.9.13:6de2ca5, May 17 2022, 16:36:42) [MSC v.1929 64 '
'bit (AMD64)]')
'os=Windows-10-10.0.19044-SP0'
'numpy=1.23.1'
'asammdf=7.1.1'
MDF version
v4.11
Description
Have a CAN log with GPS latitude and longitude signals.
When trying to create a GPS window in the GUI, the leaflet maps doesn't seem to load up and display.
See below the error message showing up in the console in the first screenshot.
See the latitude and longitude signals trying to be displayed on the map but on a plot in the second screenshot.
The text was updated successfully, but these errors were encountered: