Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Node.js 13 #13

Merged
merged 2 commits into from
Mar 13, 2020
Merged

Add support for Node.js 13 #13

merged 2 commits into from
Mar 13, 2020

Conversation

tony-ho
Copy link
Contributor

@tony-ho tony-ho commented Mar 10, 2020

The theme currently fails to build with Node.js 13 (including the Travis CI builds) due an error with the version of sharp in use.

The underlying issue appears to be lovell/sharp#1909, which is resolved by upgrading sharp to version 0.23.x.

The following theme dependencies have been bumped to force sharp version 0.23.1:

  • gatsby-plugin-sharp to 2.2.26
  • gatsby-transformer-sharp to 2.2.18

Demo dependency gatsby-plugin-favicon has been replaced by gatsby-plugin-manifest due to the following issue with gatsby-plugin-favicon preventing sharp from being upgraded: Creatiwity/gatsby-plugin-favicon#64

Bump dependencies to force `sharp` version ^0.23.1.
This is the minimum version required to support Node.js 13.
Replace `gatsby-plugin-favicon` with `gatsby-plugin-manifest` to allow
`sharp` ^0.23.1 to be used.
This is the minimum version required to support Node.js 13.
@danielhusar danielhusar merged commit 5c97446 into danielhusar:master Mar 13, 2020
@danielhusar
Copy link
Owner

This is great, thanks!

@tony-ho tony-ho deleted the node-13 branch March 13, 2020 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants