Skip to content
This repository has been archived by the owner on Sep 27, 2018. It is now read-only.

Elm 0.19 #2

Open
arsduo opened this issue Aug 25, 2018 · 3 comments
Open

Elm 0.19 #2

arsduo opened this issue Aug 25, 2018 · 3 comments

Comments

@arsduo
Copy link

arsduo commented Aug 25, 2018

I don't know how much has changed in the underlying core libraries and thus how large of a lift it will be to upgrade elm-semantic-dom to support Elm 0.19, but I'd be happy to help!

I've been using elm-modular-ui both at work and at home and really like it.

@danielnarey
Copy link
Owner

@arsduo -
I think a basic upgrade of elm-semantic-dom to be compatible with 0.19 is the first step to moving the Modular UI framework forward. If you'd like to get a start on this and submit a pull request, that's fine by me.

You can try running elm-upgrade and see how far that gets you. The README also recommends running elm-format with an upgrade option — I'm not sure what effect this will have because some of my code formatting is purposefully unconventional, which is why I have avoided elm-format thus far.

Note that using Dom as the base module name is no longer a problem because elm-lang/dom has been incorporated into elm/browser (which is a much better description for the functionality of that collection of modules!). I think this consolidated package is the biggest overall improvement to the 0.19 architecture, and I can now archive elm-semantic-effects.

Looking at your projects, I'm glad you've been able to extend Modular UI with elm-ui-drag-drop. I think some functionality like this could eventually be incorporated in the framework (it's more complex but analogous to the helpers for key press events in Ui.Action). If you have a working example that uses this package, I'd like to try it out.

@arsduo
Copy link
Author

arsduo commented Sep 12, 2018

Hi @danielnarey -- sorry about the late response! I had some other stuff come up and wasn't able to look into 0.19 earlier.

If you haven't started working on the upgrade yet (I don't see a branch), I have some time this afternoon and will see how far I can get with elm-upgrade. I'll try to avoid running elm-format if I can to avoid breaking your formatting and creating a ton of unnecessary changes.

I would be very glad to talk about what parts of elm-ui-drag-drop could be pulled into the framework! It was a fun challenge. I'm currently using it on two private projects (one personal, one at eSpark) and can pull out a working example in the next month (or figure out a way to get you access to one of the projects using it).

@danielnarey
Copy link
Owner

I started to do some planning here to consolidate parts of the Semantic Dom and Modular UI packages, but I haven't started working on the code yet. If you haven't started on the upgrade, maybe hold off for the moment, or submit a pull request for anything you have done. I should have time to get a dev branch started in the next couple days, and I think it will come together quickly from there.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants