Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export a NextRouterState type for TypeScript? #86

Closed
JoshuaKGoldberg opened this issue May 14, 2022 · 0 comments · Fixed by #88
Closed

Export a NextRouterState type for TypeScript? #86

JoshuaKGoldberg opened this issue May 14, 2022 · 0 comments · Fixed by #88

Comments

@JoshuaKGoldberg
Copy link
Contributor

JoshuaKGoldberg commented May 14, 2022 •
edited
Loading

Hi, I just found this library while converting an app written in TypeScript from CRA+react-router to Next.js. Thank you so much for saving me from having to refactor a bunch! 💖

One small point: there's no good exported type I can find for the router part of state. Back in connected-react-router land we had RouterState. Could this library please export an equivalent?

It looks like

connected-next-router/src/types.ts

Line 10 in c2b0787

export type RouterState = {
is what I'm looking for? But it's not exported right now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added exports for action and state types
1 participant
@JoshuaKGoldberg