Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RGB colors in derived-variables.sass are invalid caused by missing bulmaToRGB function #68

Closed
Way opened this issue Feb 16, 2022 · 1 comment · Fixed by #42
Closed
Labels
bug Something isn't working

Comments

@Way
Copy link

Way commented Feb 16, 2022

This is about Bulma.
It's a bug in the library.

Overview of the problem

This is about the Bulma CSS framework

This is a Sass issue: I'm using version 1.47.0
I am sure this issue is not a duplicate?

Description

All variables in bulma/sass/utilites/derived-variables.sass that use bulmaToRGB are not set correctly because the bulmaToRGB function is missing (not imported) from the bulma/shared/functions.sass file.
The bulmaToRGB is only defined in the bulma/sass/utilites/functions.sass.

Possible solution would be to import shared/functions.sass into utilities/functions.sass or just to duplicate the bulmaToRGB function from bulma/shared/functions.sass into utilities/functions.sass.

Steps to Reproduce

As you can see in this jsbin, the bulma delete button is invisible because its background-color is missing caused by missing bulmaToRGB sass function.

https://jsbin.com/lekikor/1/edit?html,output

Expected behavior

The RGB colors in derived-variables.sass should be transformed to their actual values.

Actual behavior

The RGB colors in derived-variables.sass have invalid values like background-color: rgba(var(--scheme-invert-rgb, bulmaToRGB(#0a0a0a)), 0.2);

@daniil4udo daniil4udo added the bug Something isn't working label Feb 17, 2022
@daniil4udo daniil4udo linked a pull request Feb 17, 2022 that will close this issue
@daniil4udo
Copy link
Owner

@Way thank you so much for you find.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants