Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support setting image_size=(width, height) #45

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

hzsydy
Copy link

@hzsydy hzsydy commented Mar 19, 2019

No description provided.

@nkolot
Copy link
Collaborator

nkolot commented Mar 25, 2019

Did you verify that it still passes the existing test cases? I cannot test it myself for the next few days.

@hzsydy
Copy link
Author

hzsydy commented Mar 27, 2019

Even daniilidis-group/neural_renderer branch itself cannot pass the test cases.
Renderer.render() now returns a tuple instead of a single image, so most of the test cases just failed.

@hzsydy hzsydy closed this Apr 2, 2019
@hzsydy
Copy link
Author

hzsydy commented Apr 2, 2019

fix a bug in orig_size I wrote, which is not tested in testcase lol

@hzsydy hzsydy reopened this Apr 2, 2019
@nkolot
Copy link
Collaborator

nkolot commented May 22, 2019

Sorry for not being very responsive. What is the status of this PR?

@hzsydy
Copy link
Author

hzsydy commented May 23, 2019

I believe it works (because I am using it now), but not exactly sure.

@nkolot
Copy link
Collaborator

nkolot commented May 23, 2019

From a quick look it doesn't not break backwards compatibility. I will try to write some small unit tests, and if it passes I will merge it.

@EricCousineau-TRI
Copy link

FWIW I think I've done some basic fixing of unittests in #115 (well, relaxing the failing mask intersections at least)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants