-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is it using for Roust Line Regression? #24
Comments
It does not have code for 2D line fitting but should be reasonably easy to implement if needed. Is it still relevant? |
It would be great if you had the time to implement it. and I will try to implement it. Thanks for your reply! |
On a related note, it it possible to get a generic implementation that would require the user to provide their own model with a suitable (weighted least squares) fitting function? |
Robust line fitting is available: https://github.com/danini/magsac/blob/master/examples/example_line_fitting.ipynb |
Actually, adding new models is pretty easy. You simply have to add a new estimator into estimators.h (with LSQ and the residual function). If you want to have a Python binding for the new estimator as well, you simply have to add a new function in magsac_python.cpp and bindings.cpp. So adding new models is I would say pretty easy. |
No description provided.
The text was updated successfully, but these errors were encountered: