Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it using for Roust Line Regression? #24

Open
wuyuanmm opened this issue Oct 29, 2021 · 5 comments
Open

Is it using for Roust Line Regression? #24

wuyuanmm opened this issue Oct 29, 2021 · 5 comments

Comments

@wuyuanmm
Copy link

No description provided.

@danini
Copy link
Owner

danini commented Jun 7, 2023

It does not have code for 2D line fitting but should be reasonably easy to implement if needed. Is it still relevant?

@wuyuanmm
Copy link
Author

wuyuanmm commented Jun 15, 2023

It would be great if you had the time to implement it. and I will try to implement it. Thanks for your reply!

@tvercaut
Copy link

tvercaut commented Jul 3, 2023

On a related note, it it possible to get a generic implementation that would require the user to provide their own model with a suitable (weighted least squares) fitting function?

@danini
Copy link
Owner

danini commented Jul 4, 2023

Robust line fitting is available: https://github.com/danini/magsac/blob/master/examples/example_line_fitting.ipynb
I didn't yet to a very thorough testing, but it should work with no problem.

@danini
Copy link
Owner

danini commented Jul 4, 2023

On a related note, it it possible to get a generic implementation that would require the user to provide their own model with a suitable (weighted least squares) fitting function?

Actually, adding new models is pretty easy. You simply have to add a new estimator into estimators.h (with LSQ and the residual function). If you want to have a Python binding for the new estimator as well, you simply have to add a new function in magsac_python.cpp and bindings.cpp. So adding new models is I would say pretty easy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants