-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The result after serialize will not have included
if the input doesn't have attributes
#128
Comments
it closes the first issue you mentioned. For the empty list of attributes a major version is required because the default value of this option is a currently empty list. It needed a new issue. |
@yidongw Actually, a possible workaround to have an empty list of attributes is to use the option like that: |
@danivek thanks for this fix! I faced this bug earlier today and saw it fixed on master when checking the codebase. Would it be possible for you to create a patch release? |
@groyoh v2.6.4 🎉 |
Thanks @danivek ! 🙌 |
Considering this data
with this serializer
After serializing the data, it will not serialize the
[ 'u45', 'u46' ]
and[ 'u47', 'u48' ]
and include the results in theincluded
, unless I have some attributes in theformat
serializer and provide that attributes in theformat
in the dataAnother thing is I can't have an empty list of attributes (
whitelist
). AFAIK JSON API doesn't say we have to have attributes in the resourceThe text was updated successfully, but these errors were encountered: