Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inside package.json, why "mocha" is in dependencies, not devDependencies? #149

Closed
xiaoyuze88 opened this issue Sep 14, 2021 · 1 comment
Closed

Inside package.json, why "mocha" is in dependencies, not devDependencies? #149

xiaoyuze88 opened this issue Sep 14, 2021 · 1 comment

Comments

@xiaoyuze88
Copy link

Put "mocha" in dependencies made some issues when we build our production version of our project, should "mocha" be place in devDependencies?
@dankogai
Copy link
Owner

dankogai commented Sep 14, 2021 •
edited

You are right. I THOUGHT it was in devDependencies but it is in dependencies which should be empty since js-base64 does not depend on any other modules. It is fixed in e4362c7.

@holm holm mentioned this issue Dec 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dankogai @xiaoyuze88