Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update target frameworks #9

Closed
Bliamoh opened this issue Oct 6, 2021 · 1 comment
Closed

Update target frameworks #9

Bliamoh opened this issue Oct 6, 2021 · 1 comment

Comments

@Bliamoh
Copy link

Bliamoh commented Oct 6, 2021

Currently, supported target frameworks are:

<TargetFrameworks>netstandard1.1;netstandard2.0;netstandard2.1;net45;net48;net5.0;netcoreapp3.1</TargetFrameworks>

However, these list of frameworks have two issues:

  1. .NET Standard versions (1.1, 2.0, 2.1) already cover specific versions (like .NET 4.5), meaning it's an unecessary duplication.
  2. Some of them (.NET Standard 1.1 and .NET Framework 4.5) cover unsupported versions.

Here are some references to understand what I am talking about:

Unecessary duplications

As you can see in the dynamic table of versions covered by .NET Standard:

  • .NET Framework 4.5 is already covered by .NET Standard 1.1
  • .NET Framework 4.8 is already covered by .NET Standard 1.1, 2.0 and 2.1
  • .NET Core 3.1 is already covered by .NET Standard 1.1, 2.0 and 2.1
  • .NET 5.0 is already covered by .NET Standard 1.1, 2.0 and 2.1

So you could simplify it like this:

<TargetFrameworks>netstandard1.1;netstandard2.0;netstandard2.1</TargetFrameworks>

Unsupported versions

The main question about this point is to know if why there is a direct reference to .NET Framework 4.5?
Because .NET Framework 4.5 is not supported anymore since January 12, 2016. Furthermore, even if .NET Framework 4.5.2 is still supported, its support will end on April 26, 2022 so it could be a good idea to anticipate and change this now.
Moreover, .NET Framework 4.5.2, 4.6 and 4.6.1 versions support will end on April 26, 2022 so, as you can see in the dynamic table of versions covered by .NET Standard, .NET Standard 1.1 will soon become useless. So, the final version of targeted frameworks should be:

<TargetFrameworks>netstandard2.0;netstandard2.1</TargetFrameworks>

I am raising this issue because I am using your librairy and if its covering unsupported framework versions, then it may lead to security issues that my clients are concerned about.
So I would be glad to open a PR to fix that and do whatever is necessary for you to release a new version with these modifications.

@danm-de
Copy link
Owner

danm-de commented Oct 6, 2021

Thanks for the PR!

@danm-de danm-de closed this as completed Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants