Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider regenerating completions on bashly generate #86

Closed
DannyBen opened this issue Jul 21, 2021 · 1 comment · Fixed by #144
Closed

Consider regenerating completions on bashly generate #86

DannyBen opened this issue Jul 21, 2021 · 1 comment · Fixed by #144
Labels
enhancement New feature or request

Comments

@DannyBen
Copy link
Owner

Right now, the only way to regenerate the bash completions function is by rerunning bashly add comp function.

The reasons it is like this are:

  1. Different users will choose different places to integrate these completions
  2. There is no place in the config file to specify things like "and also regenerate completions"

Although it seems like a high level of effort for the time being to change this, from user perspective, it is most definitely needed.

It would be nice if bashly generate is smart enough to know how completions were added, and redo the same thing.

@DannyBen DannyBen added the enhancement New feature or request label Jul 21, 2021
This was referenced Oct 29, 2021
@DannyBen
Copy link
Owner Author

DannyBen commented Oct 29, 2021

Implemented in the master branch, but only on completions that were added using bashly add comp function.

Once the version is released, users already having such completions need to re-add them once with --force and from this point on, running bashly generate --upgrade will also regenerate the function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant