Refactor Desktop Environment support #162
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannyedel
force-pushed
the
refactor-desktop-support
branch
from
66dcec6
to
4c9a5fc
Compare
The simple forwarder to QWidget is generic enough to be moved inside DesktopSupport base class. Also, add a canMoveWindowWhileFullscreen() test to the implementations, and only if false dspdfviewer.cpp will un-fullscreen both windows before moving them.
dannyedel
force-pushed
the
refactor-desktop-support
branch
from
cf41af4
to
6c72240
Compare
It seems to get ignored when prefixed with a dot
desktopsupport.h uses std::string, but didn't include it
|
Note to self: Give solid error messages if started in 2screen mode with only one output connected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal: replace
#if WIN32 #elseifcompile-time madness with clean, runtime-chosen modules.fixes #161