Add default material #7
Assignees
Comments
Dannyps
added a commit
that referenced
this issue
Oct 19, 2018
* Add example demo: * Add example yas file * Make ids somewhat meaningfull * Fix indexes for the yas format * Basic support for ortho views * Add special values * Add new logging and error checking functions * Finished parseScene * Make yas axis_length used. Will only work when full yas file is properly parsed. * Minor reformatting. * Add dtd for yas. Might be incorrect. * Added some defaults * Removed attempts to parse content for which the parser isn't implemented Otherwise there will be errors, thus the scene is not loaded at all * Implemented parser for ambient tag * Added statement to change scene background color * Fixed issue where forEach wasn't invoked properly I forgot to use the call() method, because I am using forEach on an Array-like object * Fixed issue where errors weren't being properly checked in parseAmbient * Updated example-yas to implement ambient tag * Changed error severity in ambient parser * Refactored Ambient parsing * Working in a generic parser with built-in methods Added methods to ensure required attributes for a given element are set Added method to ensure the attribute value is valid Added mechanisms to use default values whenever is possible * Fixed issues in Generic Parser Fixed getOwnPropertyNames() invoke Fixed onXMLError() and onXMLMinorError() invoke Fixed isNaN() invoke Fixed data type checking when parsing attribute values * Updated Ambient parser to use generic parser as super class * Cleanup ambient parser * Added methods to improve messages error * Improved documentation on GenericParser * Added new method in GenericParser to parse child elements * Minor fix * Small tweaks in _parseUniqueChildElements * Updated Ambient parser to use latest auxiliary methods * Added parser for Scene * Fixed issue where the parser wouldn't stop upon errors * Added preview parser for lights * Enabled new light and scene parsers * Provide a better base for the xml race * This yas file should show a square * Added materials * Add logging capabilities to GenericParser * Load the Textures.js parser * Fixed light values * Add checking for repeated entries * Fixed materials definition location * Added primitives * Add Materials parsing * Add cube * Auto stash before merge of "example-demo" and "origin/example-demo" * It makes sense in my head :) * Changed defaults and fixed fallback values I set the default values to match the CGFappearance Fixed the defaultValues parameter when calling _parseAttributes. Copying and Pasting has this sort of side effects :D * Moved all parser related code to a sub-folder Just to keep the working directory clean and organized * Fixed #2: missing closing tags in XML. * Change from dtd to xsd * Initial version for Primitives parser * Added MyRectangle primitive * Fixed typo in MyRectangle * Temporarily commenting some primitives definitions for testing purposes * Minor fixes in Primitives parser and added Rectangle support * Removed no longer required code * Small tweak to deal with cases where default values are not provided * Added support to triangle primitives * MyCylinder (not tested, maybe not finished) * Added MyCylinder * Fixed issue related with radius calculation * Added MyCircle * Added covers to MyCylinder * Add Transformations parser * Update Library * Add primitives to main * Add missing primitives to main include * Updated default ambient light values * Updated ambient light * Fixed default 'w' component for omni lights * Make Traingles' Normals dynamic & delete unused files * Prep the way for the sphere * Add parsing for spot lights * Add Spot Lights * Finished MySphere * Reviewed scene parser * Added parser for perspective views * Extended support for ortho views (don't work tho) * Cleaned code for ambient data * Reviewed lights and cleaned some code * Reverted previous changes to avoid issues with variable scope * Reviewed textures * Fixed #8 * Components are done. (#9) * Begin work on components parser * Further work on the Components parser * Further work on the components parser * Components' transformations are being parsed * Root component cleanup * Show components on Console * Preparing for making things move * Parse Components' Materials and Textures * Support for drawing the primitives * Extended support for components childs * Fixed transformation application order * Fixed cube definition * Fixed performance issue * Added some error checking * Fixed #7 * Added basic support for materials * Small simplification * Preparing to support M key press to update materials * Update the materials upon M key press * Add Texture support * Fixed small issue when applying textures * meh * Fixed glitch when switching materials * Fixed views initialization; Default view is now set on load * Fix textures scaling * New xsd file * Add a proper semaphore * Add other semaphore lights * Add .nojekyll file to github
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
diffuse white
The text was updated successfully, but these errors were encountered: