-
Notifications
You must be signed in to change notification settings - Fork 731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development #301
Development #301
Conversation
Drop the mixed keyword/dict interface in favor of keywords only. Add docstrings based on Google format.
Was just looking over your last commit and saw this small mistake, great work! I like the new generator approach to pagination.
Also add docstring comments about paginated request paramters.
This move was made so get_product_trades can return a generator like all other paginated API endpoints.
…anup AuthenticatedClient overhaul, docstrings, and testing
Fix heartbeat subscribe message not containing sequence
Hi what are you attempting to do here/ what's the issue? |
Sorry for the slow response. The issue seemed fairly simple -- the function get_product_trades() has several arguements, one of which is "limit". This arg was being assigned a default value of '' ... that is: limit='' ... this is causing a problem in the function when limit is used as an integer. I was attempting to change the function definition to "limit=0" ... however I suck at git (and don't really care to unsuck) and as a result don't know what has been pushed or pulled for review. |
Ive fixed this in #311 |
Great.
…-daniel
On Mon, Aug 6, 2018 at 4:33 PM alimcmaster1 ***@***.***> wrote:
Ive fixed this in #311 <#311>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#301 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAwqLNYw_jcisv1sWtSjZPPoHWOfmOiNks5uONIxgaJpZM4Uh41y>
.
|
This is fantastic. I merged the changes. Thank you all for your contribution on this. |
get_product_trades() was incorrectly setting default value of limit argument to string '', rather than int 0.