-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: rename drawer to tabs + drawer #147
Conversation
Someone is attempting to deploy a commit to the ronin-tech Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
You'll need to also update the rest of the app to use "Drawer + Tabs". See |
Thanks for the heads up! I've updated all instances of "drawer" to "tabs + drawer". Let me know if there's anything else you'd like me to check. |
0f1db32
to
c2b650c
Compare
Does running this work for you? |
Whoops! Missed a few spots in my last update. 🙈 Fixed up those references to "drawer" in the other files. Should be good to go now. Let me know if there's anything else I can do. This is what it now looks at my end:
|
@neerajkumarc Apologies for the delayed response. I just realized that the way the drawer is implemented, it actually is just a drawer. We should implement a "Drawer + Tab" template for navigation, if you are interested in giving that a shot. It would be a mirror of the existing "tabs" option but with an added drawer that allows you to pull up a page that is not part of either tab. Here is a video of the current drawer implementation to show that it does not use tabs atm. Separately, we should change the name of the screens from "Tab One" and "Tab Two" to "Screen 1" and "Screen 2" if it is using the "drawer" option. Simulator.Screen.Recording.-.iPhone.14.Pro.-.2024-01-03.at.14.15.09.mp4 |
Can I jump in on this one, I have template that I have started on personally that has drawer and tabs amongst many other things which we can add to this project too. Screen.Recording.2024-01-10.at.19.52.20.mov |
closing in favor of #159 |
closes #144