Skip to content

Commit

Permalink
Move Board now takes account of Board status, fixing #88.
Browse files Browse the repository at this point in the history
  • Loading branch information
dantarian committed Oct 12, 2018
1 parent 631156d commit 2e7b4a5
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions app/controllers/boards_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ def destroy

def move_up
selected_board = Board.find( params[:id] )
target_board = Board.where('"order" < ?', selected_board.order).last
target_board = Board.where('"order" < ? and closed = ?', selected_board.order, false).last

if target_board
selected_board.order, target_board.order = target_board.order, selected_board.order
Expand All @@ -128,7 +128,7 @@ def move_up

def move_down
selected_board = Board.find( params[:id] )
target_board = Board.where('"order" > ?', selected_board.order).first
target_board = Board.where('"order" > ? and closed = ?', selected_board.order, false).first

if target_board
selected_board.order, target_board.order = target_board.order, selected_board.order
Expand Down

0 comments on commit 2e7b4a5

Please sign in to comment.