Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Base24 support #252

Open
LovingMelody opened this issue Feb 8, 2024 · 4 comments
Open

Feature Request: Base24 support #252

LovingMelody opened this issue Feb 8, 2024 · 4 comments
Labels
feature A new feature or a feature request

Comments

@LovingMelody
Copy link

LovingMelody commented Feb 8, 2024

The underlying base16 library now supports the tinted-theming spec aka base24. Would be nice to see this included to add more colors to themes. With base24 being compatible with base16 this could be done in slow stages.

@KiaraGrouwstra
Copy link

when this lands here, the base24 github org offers implementations for a couple of applications we might use here then

@danth danth added the feature A new feature or a feature request label Feb 10, 2024
@RANKSHANK RANKSHANK mentioned this issue Mar 2, 2024
11 tasks
@Lord-Valen
Copy link

Lord-Valen commented Jun 11, 2024

Since https://github.com/tinted-theming/base24/blob/master/styling.md#base24-fallbacks is a thing, and base16-nix always generates a base24 compatible value according to that fallback rule, we should be able to just start doing this. In other words: It appears as though we already have the base24 schemes, we just aren't using them.

@danth
Copy link
Owner

danth commented Jun 11, 2024

Yep, I don't see any reason not to start implementing this on a module-by-module basis.

@trueNAHO
Copy link
Collaborator

It appears as though we already have the base24 schemes, we just aren't using them.

Yep, I don't see any reason not to start implementing this on a module-by-module basis.

Agreed. Until VIM highlight groups are implemented, supporting base24 schemes seems reasonable:

The solution I'm considering mimics vim's highlight groups

VIM's highlight groups might be the most scalable and practical solution I know of.

It would resolve nearly all our open issues regarding color scheme scalability. Additionally, our documentation could simply link to VIM's highlight groups documentation.

-- #249 (comment)

Note that implementing VIM highlight groups is a non-trivial task. Supporting base24 yields faster and easier results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature or a feature request
Projects
None yet
Development

No branches or pull requests

5 participants