Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emacs: add support for doom variant #97

Open
rockofox opened this issue May 1, 2023 · 6 comments
Open

emacs: add support for doom variant #97

rockofox opened this issue May 1, 2023 · 6 comments
Labels
feature A new feature or a feature request

Comments

@rockofox
Copy link

rockofox commented May 1, 2023

It doesn't work yet, as it's a different package and has slightly different options, see https://github.com/nix-community/nix-doom-emacs/blob/2b34bf438c9e748c34162e0a7c038c5b67688c11/modules/home-manager.nix

@SomeGuyNamedMay
Copy link
Contributor

SomeGuyNamedMay commented May 2, 2023

i believe this project is only planing on supporting home-manager and nixpkgs, it the reason i maintain a personal fork of hyprland, once you actually set up a fork though you shouldnt have to change much

@danth
Copy link
Owner

danth commented May 2, 2023

Once we have a reliable solution to #89, it will be easier to support extras like Doom and Hyprland, as they can just be disabled when the module isn't installed. That might take a while however, as the cause seems to be an issue with the module system itself.

@danth danth added the feature A new feature or a feature request label May 3, 2023
@SomeGuyNamedMay
Copy link
Contributor

SomeGuyNamedMay commented May 20, 2023

@rockofox this should be doable now

@danth danth changed the title Doom Emacs support emacs: add support for doom variant Apr 22, 2024
@Pacman99
Copy link

Pacman99 commented Sep 11, 2024

This support could also be added in the nix-doom-emacs flake similar to how the niri-flake checks if stylix is added and sets styling options for niri.

For anyone trying to add stylix support to doom, this commit shows how I did it in my nixos repo: https://gitlab.com/coffeetables/lower/-/commit/4918c0ff4c4e7580509511699a556f59c317f9ad. I'm using nix-doom-emacs-unstraightened, but the process should be the same as nix-doom-emacs.

@KamWithK
Copy link

KamWithK commented Oct 12, 2024

This support could also be added in the nix-doom-emacs flake similar to how the niri-flake checks if stylix is added and sets styling options for niri.

For anyone trying to add stylix support to doom, this commit shows how I did it in my nixos repo: https://gitlab.com/coffeetables/lower/-/commit/4918c0ff4c4e7580509511699a556f59c317f9ad. I'm using nix-doom-emacs-unstraightened, but the process should be the same as nix-doom-emacs.

This works for normal emacs but not the client

Instead I used this in my config.el:

(use-package! base16-stylix-theme)
(require 'base16-stylix-theme)
(setq doom-theme 'base16-stylix)

Also config.programs.emacs.extraPackages already contains the package base16-stylix-theme which helped to simplify mine down

@KamWithK
Copy link

KamWithK commented Oct 12, 2024

This support could also be added in the nix-doom-emacs flake similar to how the niri-flake checks if stylix is added and sets styling options for niri.

For anyone trying to add stylix support to doom, this commit shows how I did it in my nixos repo: https://gitlab.com/coffeetables/lower/-/commit/4918c0ff4c4e7580509511699a556f59c317f9ad. I'm using nix-doom-emacs-unstraightened, but the process should be the same as nix-doom-emacs.

Was there a reason for commenting out the doom package? I didn't do that, I just changed the theme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature or a feature request
Projects
None yet
Development

No branches or pull requests

5 participants