Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solves slider and image positioning problem in Firefox #109

Merged
merged 4 commits into from
May 29, 2017

Conversation

xuv
Copy link
Contributor

@xuv xuv commented Apr 23, 2016

Solves issue #108

@xuv xuv changed the title Solves slider and image positioning problem in Firefox #108 Solves slider and image positioning problem in Firefox Apr 23, 2016
@danvk
Copy link
Owner

danvk commented Apr 27, 2016

Thanks for this change. I can see the broken "Swipe" behavior in Firefox and verify that your change fixes it.

I do not see the missing slider, however. I'm using Firefox 44.

I also notice that after your change, clicking on the slider produces an unsightly box in Firefox:
screen shot 2016-04-26 at 11 36 19 pm

If you can get this to go away, I'll be happy to merge. Thanks for contributing to webdiff!

@xuv
Copy link
Contributor Author

xuv commented Jun 29, 2016

Sorry. Took a while. Was a bit busy for some time. But the dotted border in Firefox is gone now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants