Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inline codediff #185

Merged
merged 15 commits into from
Jun 6, 2024
Merged

Inline codediff #185

merged 15 commits into from
Jun 6, 2024

Conversation

danvk
Copy link
Owner

@danvk danvk commented Jun 5, 2024 •
edited
Loading

This will simplify development and aid Reactifying codediff.

Highlights:

  • Moved codediff.js into this repo and ported the tests to TypeScript + Jest. Using jQuery with Jest works surprisingly well. All tests pass except for one involving highlight.js language detection. This seems to work very poorly in general, and I'm curious how this test ever passed.
  • Vendored jsdifflib and ported it to TypeScript. There's an npm package version of it available, but it seems to have some weird global variable issues. So does the original. difflib.js looks far more popular and maintained, so maybe I should switch to that in another PR.
  • Enabled source maps for debugging.

The new files aren't prettier-formatted. I'll leave that for another PR.

@danvk danvk marked this pull request as ready for review June 6, 2024 14:34
@danvk danvk merged commit dd1cbf6 into master Jun 6, 2024
2 checks passed
This was referenced Jun 6, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@danvk