Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check permissions when registering a new scheme in controller #45

Closed
jellegerbrandy opened this issue Jul 15, 2017 · 3 comments
Closed

Comments

@jellegerbrandy
Copy link
Contributor

I.e. rewrite this line in registerScheme:

/* require(bytes4(15)&(_permissions^scheme.permissions)&(~schemes[msg.sender].permissions) == bytes4(0)); */

@leviadam
Copy link
Contributor

leviadam commented Aug 4, 2017

Hi @jellegerbrandy,

Can you tell what is the status with this issue?
In the code there is a comment:
// XXX: Commented these next line as they led to errors and I cannot understand the code

But the line is currently not commented and all tests are working.

@jellegerbrandy
Copy link
Contributor Author

its a leftover i forgot and can be removed

@leviadam
Copy link
Contributor

leviadam commented Aug 4, 2017

Done.

@leviadam leviadam closed this as completed Aug 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants