Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Visit Website" hyperlink is reading wrong externalsite url from contract #54

Closed
mrkart opened this issue Aug 19, 2022 · 5 comments
Closed

Comments

@mrkart
Copy link

mrkart commented Aug 19, 2022

https://www.flow-nft-catalog.com/catalog/mainnet/DisruptArt

"Visit Website" hyperlink was supposed to be taken from line 147 externalURL

//
 return MetadataViews.NFTCollectionDisplay(
                        name: "DisruptArt Collection",
                        description: "Discover amazing NFT collections from various disruptor creators. Disrupt.art Marketplace's featured and spotlight NFTs",
                        externalURL: MetadataViews.ExternalURL("https://disrupt.art"),
                        squareImage: media,
                        bannerImage: media,
                        socials: {
                            "twitter": MetadataViews.ExternalURL("https://twitter.com/DisruptArt"),
                            "instagram": MetadataViews.ExternalURL("https://www.instagram.com/disrupt.art/"),
                            "discord" : MetadataViews.ExternalURL("https://discord.io/disruptart")
                        }
                    )
                    //
                But it is taking wrongly from sample wallet address's token's externalURL from line 126. 
@bshahid331
Copy link
Contributor

Can you elaborate? The URLs seem the same on the contract:

https://flow-view-source.com/mainnet/account/0xcd946ef9b13804c6/contract/DisruptArt

@mrkart
Copy link
Author

mrkart commented Aug 19, 2022 via email

@bshahid331
Copy link
Contributor

Can you try submitting an update to the catalog? You can update the entry

@mrkart
Copy link
Author

mrkart commented Aug 19, 2022

I logged in with the wallet, I see "DELETE PROPOSAL" as the only action available. Where can i find "Update" ?

@mrkart mrkart closed this as completed Aug 19, 2022
@mrkart mrkart reopened this Aug 19, 2022
@bshahid331
Copy link
Contributor

You can just submit a new collection with the same collection identifier and it will be treated as an update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants