Skip to content
This repository has been archived by the owner on Jul 25, 2018. It is now read-only.

Pass relevant subset of Ethereum VM test suite #7

Closed
mbrock opened this issue Sep 6, 2017 · 2 comments
Closed

Pass relevant subset of Ethereum VM test suite #7

mbrock opened this issue Sep 6, 2017 · 2 comments

Comments

@mbrock
Copy link
Contributor

mbrock commented Sep 6, 2017

No description provided.

@mbrock mbrock added this to the 1.0 milestone Sep 6, 2017
@mbrock
Copy link
Contributor Author

mbrock commented Sep 29, 2017

Going to clarify this and work on it next week.

At least now we have a good test suite runner for VMTests.

@mbrock
Copy link
Contributor Author

mbrock commented Oct 11, 2017

As of 0.10 there are only five unexplained VMTests mismatches, and the rest of the 25 mismatches are explained:

  • 12 are timeouts from the vmPerformance suite, they probably work in fact;
  • 7 are because we don't implement CALLCODE; and
  • 1 is because of precompiled contracts.

The unexplained mismatches are:

  • vmSystemOperations/ABAcalls1
  • vmSystemOperations/ABAcalls2
  • vmSystemOperations/ABAcalls3
  • vmTests/arith
  • vmTests/mktx

These all unexpectedly succeed instead of erroring. It seems like they should fail on CALL instructions, but I don't know why -- and CALL isn't really executed in the VMTests anyway, so it's kind of strange.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant