Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Azure Key Vault conformance test use environment variable for vaultName #974

Closed
CodeMonkeyLeet opened this issue Jun 25, 2021 · 1 comment · Fixed by #975
Closed
Assignees
Milestone

Comments

@CodeMonkeyLeet
Copy link
Contributor

Describe the proposal

Unlike the other conformance tests, the azure-keyvault.yaml config hardcodes the name of the target resource which creates an issue for contributors wanting to set up their own test environments. For example, different users sharing an Azure subscription may not be able to manage the permissions on the fixed name key vault individually, and will need to edit the yaml to retarget against their own keyvault instance. This also creates a stumbling block for any automation to facilitate contributors setting up their own Azure conformance test environments on demand.

The proposal is to simply update the Azure Key Vault conformance test use environment variable for vaultName in the azure-keyvault.yaml

@CodeMonkeyLeet
Copy link
Contributor Author

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants